Remove cl_icdl_private.h as it is now unneeded.#210
Merged
bashbaug merged 5 commits intoKhronosGroup:mainfrom Apr 25, 2023
Merged
Remove cl_icdl_private.h as it is now unneeded.#210bashbaug merged 5 commits intoKhronosGroup:mainfrom
bashbaug merged 5 commits intoKhronosGroup:mainfrom
Conversation
Contributor
Author
|
TODO: commit 137f0a5 should be reverted before merge. |
…Headers are merged." This reverts commit 137f0a5.
Kerilk
force-pushed
the
remove-icdl-header
branch
from
fc81a4f to
6feaadc
Compare
Contributor
Author
|
Provided CI passes this should be good for merging. |
Contributor
|
Merging as discussed in the April 25th teleconference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the final PR for the icdl/cl_loader_info extension. It removes the temporary header that was added for implementation and rely on the modified
cl_ext.hheader to provide the definitions.The CI should not succeed until KhronosGroup/OpenCL-Headers#214 is merged. I will relaunch the jobs once the aforementioned PR is merged.